fix(protocol-designer): fix save behavior for bad liquid form #17171
+30
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In liquids toolbox, we should never disable "save" when adding a liquid to wells. Rather, errors should show when save is clicked, surfacing to the user fields that need to be resolved. Here, I modify our logic for Controller rules in our form used to added liquids, and implement a volume validation function. Closes RQA-3497
koji
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In liquids toolbox, we should never disable "save" when adding a liquid to wells. Rather, errors should show when save is clicked, surfacing to the user fields that need to be resolved. Here, I modify our logic for Controller rules in our form used to added liquids, and implement a volume validation function.
Closes RQA-3497
Test Plan and Hands on Testing
Screen.Recording.2024-12-23.at.2.41.59.PM.mov
Changelog
Review requests
see test plan
Risk assessment
low