Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ms2/engine unified endpoints #434

Open
wants to merge 65 commits into
base: main
Choose a base branch
from
Open

ms2/engine unified endpoints #434

wants to merge 65 commits into from

Conversation

FelipeTrost
Copy link
Contributor

Summary

  • New type for engines Engine which includes mqtt/http and space/PROCEED engines.
  • Unified engine request interface that takes Engine and makes the appropriate request.

There are still TODOS in the code, but the basic structure is there.

@FelipeTrost
feat(ms2/engines): initial mqtt endpoints
85734b1
@FelipeTrost
feat(ms2/engines): endpoints for engines
b6b4b13
@FelipeTrost
feat(ms2/engines): mqtt requests
ff6c609
@FelipeTrost
feat(ms2/admin): engine view
1099bb6
@FelipeTrost
refactor(ms2/mqtt)
eeef5cc
@FelipeTrost
fix(ms2/engine-endpoints): import
0c815e3
@FelipeTrost
fix(ms2/admin-engines): make page dynamic
28f6d10
@FelipeTrost
feat(ms2/admin): added link to engines in sidebar
201ff18
@FelipeTrost
chore: format
e2f0b01
@FelipeTrost
Merge branch 'main' into engine/mqtt
c9eeefd
@FelipeTrost
fix(ms2/env-vars): mqtt env vars shouldn't be required yet
9ee7945
@FelipeTrost
Merge branch 'engine/mqtt' of github.com:PROCEED-Labs/proceed into en…
1797cf4 
…gine/mqtt
@FelipeTrost
fix: possible undefined
60fa7e3
@FelipeTrost
fix: engine name key
f5ce66c
@FelipeTrost
fix(ms2/build): unset env-var
ba762b9
@FelipeTrost
chore(ms2): primsa format
1bcae7c
@FelipeTrost
feat(ms2): db table for storing engines for spaces
724300a
@FelipeTrost
feat(ms2/UserErrorType ): SchemaValidationError
fb681ed
@FelipeTrost
feat(ms2/lib/data): space engines
2934351
@FelipeTrost
refactor(ms2/db): renamed space engines attribute
8157855
@FelipeTrost
fix(ms2): use ability in engine's DTOs
837be7d
@FelipeTrost
Merge remote-tracking branch 'origin/main' into engine/mqtt
107e306
@FelipeTrost
feat(ms2): name for space engines
834f7af
@FelipeTrost
feat(ms2): ui for crud on space engines
aae8142
@FelipeTrost
use feature flag
71b234b
@FelipeTrost
fix(ms2/mqtt): correct engine id key
380fe3c
@FelipeTrost
Merge remote-tracking branch 'origin/main' into engine/mqtt
4dca759
@FelipeTrost
admin-dashboard/engines: better error message
f9c841f
@FelipeTrost
fix: import
83150ef
@FelipeTrost
refactor(ms2/mqtt): remove unnecessary async wrappers
8c36c2a
@FelipeTrost
Merge branch 'ms2/space-engines' into ms2/engine-unified-endpoints
a1a9eb0
@FelipeTrost
removed console.log
8ea4ea6
@FelipeTrost
refactor(ms2/mqtt): accept custom MQTT client
6e0f529
@FelipeTrost
refactor(ms2/engines): better type for engines
95ef02f
@FelipeTrost
ms2(mqtt): deployent to spaceEngines / proceedEngines
d75186b
@FelipeTrost
feat(ms2/engines): SpaceEngine type
80d1143
@FelipeTrost
feat(ms2/db): getSpaceEngineByAddress
92637f8
@FelipeTrost
fix(ms2/deployments): handle no engines case
e01ea35
@FelipeTrost
feat(ms2/deployments): forceEngine in server actions
000a43c
@FelipeTrost
feat(ms2/deployments): getAvailableSpaceEngines server action
e476820
@FelipeTrost
better types
b92b42d
@FelipeTrost
refact0r(ms2/DeploymentSelectionView): accept containerProps
7a6db42
@FelipeTrost
feat(ms2/executions-view): static deployment
ce1bb44
@FelipeTrost
feat(ms2): allow 'Execution', 'Machine' in personalSpaces
211562b
@FelipeTrost
fix(ms2/deployments): random PROCEED engine
e2790df
@FelipeTrost
refactor: engineAccumulator checks topic
26337a5
@FelipeTrost
fix(ms2/space-engine-helper): get machineId of http space engines
df4c333
@FelipeTrost
removed todos
be3e961
@FelipeTrost
fix(ms2/space-engine-helpers): await topic subscription when getting …
c105a89 
…engines
@FelipeTrost
Merge remote-tracking branch 'origin/main' into ms2/engine-unified-en…
6c1c37f 
…dpoints
@FelipeTrost
fix(ms2): use versionId instead of version
0f10739
@FelipeTrost
fix(ms2/executions): show definitionName in table
1da6f19
@FelipeTrost
Merge remote-tracking branch 'origin/main' into ms2/engine-unified-en…
09229fe 
…dpoints
@FelipeTrost FelipeTrost force-pushed the ms2/engine-unified-endpoints branch from 0d64c4c to 09229fe Compare December 10, 2024 16:30
@FelipeTrost FelipeTrost marked this pull request as ready for review December 10, 2024 16:31
@github-actions GitHub Actions
Copy link

CLOUDRUN ACTIONS

✅ Successfully created Preview Deployment.

https://pr-434---ms-server-staging-c4f6qdpj7q-ew.a.run.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FelipeTrost