[CINN] remove cinn_pod_value_t(part1) #70503
Open
+45
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… try_to_call_cuda_kernel_launch
Comment on lines
81
to
84
| int64_t cinn_get_value_in_cuda_kernel_args(void *v_args, int idx) { | ||
| cinn_pod_value_t *args = static_cast<cinn_pod_value_t *>(v_args); | ||
| return args[idx].operator int64_t(); | ||
| KernelArgsNode *args = static_cast<KernelArgsNode *>(v_args); | ||
| return args[idx].symbol_val; | ||
| } |
There was a problem hiding this comment.
这里后续是否可以加上type的检查以便定位arg不一致问题
Comment on lines
+105
to
+106
| func_args_[i] = KernelArgsNode{ | ||
| kernel_tensor_args[i]->data(), -1, KernelArgsType::void_p_args_type}; |
zyfncg
reviewed
Dec 27, 2024
Comment on lines
+49
to
+51
| unk_args_type = -1, //! Unknown type | ||
| void_p_args_type = 0, //! void* | ||
| int64_args_type = 1, //! int64_t |
Comment on lines
+55
to
+56
| void* data_ptr{nullptr}; | ||
| int64_t symbol_val{-1}; |
There was a problem hiding this comment.
symbol_val的含义是什么，感觉需要一点注释说明？
| if (args[idx].type_code() == ::cinn_type_code<cinn_buffer_t *>()) { | ||
| kernel_args.emplace_back( | ||
| &((cinn_buffer_t *)(args[idx]))->memory); // NOLINT | ||
| // kernel_args.emplace_back( &(args[idx])); // NOLINT |
| if (args[idx].args_type == KernelArgsType::void_p_args_type) { | ||
| kernel_args.emplace_back(&(args[idx].data_ptr)); // NOLINT | ||
| } else if (args[idx].args_type == KernelArgsType::int64_args_type) { | ||
| kernel_args.emplace_back(&(args[idx].symbol_val)); // NOLINT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
PR Types
Description
为了清理nvrtc编译的头文件个数，需要清理下cinn pod value，这个pr是cinn jit kernel中，不再使用 cinn pod value
本来计划直接使用 void* 进行传递，但是会产生cuda 700 error，引入了一个新的数据结构