【HEU】[Paddle Tensor 第二期 API鲁棒性增强] paddle.roll 支持 0-size tensor 与 bool #70537
+211
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Comment on lines
30
to
32
| using Type = | ||
| typename std::conditional<std::is_same<T, bool>::value, int, T>::type; | ||
| std::vector<Type> out_vec; |
There was a problem hiding this comment.
为什么当T是bool时，out_vec的类型是int?
There was a problem hiding this comment.
下面的代码中有一个out_vec.data()的调用，但是bool类型的vertor没有这个实现，所以将对应bool类型的实现使用了int来初始化
There was a problem hiding this comment.
但是int和bool的字节数对不上，这里的TensorToVector不会出现问题吗？
test/legacy_test/test_roll_op.py
Outdated
| @@ -185,6 +185,7 @@ def input_data(self): | |||
| self.data_x = np.array( | |||
| [[1.0, 2.0, 3.0], [4.0, 5.0, 6.0], [7.0, 8.0, 9.0]] | |||
| ) | |||
| self.data_zero_x = np.array([]).reshape(0, 3).astype('float32') | |||
There was a problem hiding this comment.
--> data_x_zero_size
| with paddle.static.program_guard( | ||
| paddle.static.Program(), paddle.static.Program() | ||
| ): | ||
| x = paddle.static.data(name='x', shape=[0, 3], dtype='float32') |
There was a problem hiding this comment.
可以多测试几种不同的0-size+shift+axis的组合
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
解决了roll的输入为0size时的情况，为roll增加了bool类型支持
这个测试需要isnan支持复数，下面的pr正在做
#70126