Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackathon 7th No.55] Add audiotools to PaddleSpeech #3900

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Nov 20, 2024

PR types

New features

PR changes

APIs

Describe

audio/audiotools/audio_signal.py 中,注释中打✅的均为通过测试的方法,打❌的为未通过 | 未适配

当前进度

  • audio_signal
  • util
  • audiotools.decorators
  • audiotools.data
  • audiotools.metrics
  • unitest
  • 移除代码中的✅❌
  • 移除文件名字中的✅❌

Copy link

paddle-bot bot commented Nov 20, 2024

Thanks for your contribution!

_original_num_channels = None
_padded_signal_length = None

# def _preprocess_signal_for_windowing(self, window_duration, hop_duration):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there are so many code annotations?

audio/audiotools/__init__.py Show resolved Hide resolved
audio/audiotools/core/_julius.py Show resolved Hide resolved
audio/audiotools/core/_julius.py Outdated Show resolved Hide resolved
audio/audiotools/core/_julius.py Outdated Show resolved Hide resolved
audio/audiotools/core/audio_signal.py Show resolved Hide resolved
class AudioSignal(
EffectMixin,
LoudnessMixin,
# PlayMixin,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this line annotated?

@zxcd
Copy link
Collaborator

zxcd commented Dec 18, 2024

  1. All you test should be added to tests/unit/cli/test_cli.sh to trigger unit test.
  2. Also to reduce the repetition of code, it is recommended that you write a separate bash file for voice download in the single test, and after downloading the voice, read it separately from different python files.
  3. To ensure accurate alignment, it is recommended to add the current alignment accuracy value in the single measurement annotation, normally fp32 requires 1e-6.
  4. Remove symbols and commented out useless code from single test file names.

@zxcd
Copy link
Collaborator

zxcd commented Dec 19, 2024

开发者你好,感谢你的参与!由于你的黑客松赛题完成度较高,其PR已被锁定,请尽快完善锁定的PR,并确保在2025年1月3日前完成合入。逾期未合入PR将无法获得奖金发放。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants