-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lxml (B320 & B410) from blacklist #1212
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion:
- We should do this
- We should add very clear notes to our changelog
- We should start pointing people away from defused XML as it's maintenance status means lxml is likely to be safer going forward
38d68e6
to
19c5f09
Compare
I couldn't find any changelog files. @ericwb do you know what Ian meant? |
My mistake. I thought we had one but I guess not |
@sigmavirus24 thank you for your reply! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So when removing a rule, we should keep the documentation for historical reasons and denote that the plugin or test was removed. This is to prevent someone in the future accidentally reusing the same Bandit ID number, thus leading to a conflict.
As for the code for the test, we can disable is functionality but keep it in order to reserve the Bandit ID associated with it.
For example, see the following. Notice how we kept the docs and denoted that the plugin was removed in what version. Please follow this example.
https://bandit.readthedocs.io/en/latest/blacklists/blacklist_calls.html#b309-httpsconnection
https://bandit.readthedocs.io/en/latest/blacklists/blacklist_calls.html#b322-input
https://bandit.readthedocs.io/en/latest/blacklists/blacklist_calls.html#b322-input
thank you @ericwb for the review! |
removes B320 (xml_bad_etree) and B410 (import_lxml)
fixes #767