Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove font preloading (DO NOT MERGE) #7068

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thejackshelton
Copy link
Member

The qwikVite plugin currently preloads all font files without being overridable, negatively affecting performance.

I am testing this release link in order to see just how big that gap is.

for more info:
https://www.youtube.com/watch?v=uHln79_SQjs

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@thejackshelton thejackshelton requested a review from a team as a code owner November 17, 2024 15:18
Copy link

changeset-bot bot commented Nov 17, 2024

⚠️ No Changeset found

Latest commit: 7c72e31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 17, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7068
npm i https://pkg.pr.new/@builder.io/qwik-city@7068
npm i https://pkg.pr.new/eslint-plugin-qwik@7068
npm i https://pkg.pr.new/create-qwik@7068

commit: 7c72e31

Copy link
Contributor

github-actions bot commented Nov 17, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 7c72e31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant