Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffering #7123

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix buffering #7123

wants to merge 3 commits into from

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Dec 2, 2024

Description

This is an effort to fix the "buffering" component of Qwik so there will be ZERO delays on interactions for SPA.

Things to get done

  • Add ALL dynamic dependencies to the graph
  • Simulate and fix the "fetching unrelated routes" problem
  • Implement the addition of <Link> routes entry bundles (roots)
  • Rename "Prefetch SW" to "Preloader"

Merging Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: a11810a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shairez shairez force-pushed the pr-fix-buffering branch 2 times, most recently from 4c223ba to 0b5ac35 Compare December 2, 2024 23:37
@JerryWu1234
Copy link
Contributor

I have done this item

Rename "Prefetch SW" to "Preloader"

@shairez
Copy link
Contributor Author

shairez commented Dec 24, 2024

I have done this item

Rename "Prefetch SW" to "Preloader"

thanks @JerryWu1234
this should be done after we have fixed all the previous tasks, because we still have to sync it with V2 and it'll be harder to do after renaming

Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7123
npm i https://pkg.pr.new/@builder.io/qwik-city@7123
npm i https://pkg.pr.new/eslint-plugin-qwik@7123
npm i https://pkg.pr.new/create-qwik@7123

commit: a11810a

Copy link
Contributor

github-actions bot commented Dec 24, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview a11810a

@JerryWu1234
Copy link
Contributor

this should be done after we have fixed all the previous tasks, because we still have to sync it with V2 and it'll be harder to do after renaming

I'll continue after finish all the tasks. or Do I have to close My PR first ?

@JerryWu1234
Copy link
Contributor

JerryWu1234 commented Dec 24, 2024

@shairez

Sorry for asking, but I feel like I might have missed something.
I guess q-bundle-graph this is a graph that you mentioned.
and I have checked that format.

[
  "../service-worker.js",
  "q-5xTo4sT3.js",
  33,
  "q-B5JT6P0A.js",
  51,
  "q-BSsfhJZi.js",
  63,
  "q-BbGl-ZpR.js",
  75,
  "q-Bc-7g2QP.js",
  22,
  "q-BjvrIWZn.js",
  75,
  "q-BjzFP4GB.js",
  63,
  "q-Bxg2XPPi.js",
  75
]

I want to confirm what kind of format addition of the graph uses and its name.
Do you mean <Link> routes entry bundles is the same as a router list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants