Allows the proper use of --no-optimize in --moar-option #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, even if --moar-option="--no-optimize" was used, the "--optimize" switch was still added to MoarVM's invocation of ./Configure.pl. This patch addresses that issue.
niner
requested changes
Dec 1, 2021
| @@ -331,7 +331,7 @@ sub gen_moar { | |||
| my $force_rebuild = $options->{'force-rebuild'}; | |||
| my $has_gen_moar = defined $gen_moar; | |||
| my @opts = @{ $options->{'moar-option'} || [] }; | |||
| push @opts, "--optimize"; | |||
| push @opts, "--optimize" unless grep('--no-optimize', @{ $options->{'moar-option'} }); | |||
There was a problem hiding this comment.
I don't think, this works as intended. It will still always set --optimize:
> perl -E 'say grep("d", qw(b a c));'
bac
> perl -E 'say grep({$_ eq "d"} qw(b a c));'
> perl -E 'say grep({$_ eq "a"} qw(b a c));'
a
lizmat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, even if --moar-option="--no-optimize" was used, the "--optimize" switch was still added to MoarVM's invocation of ./Configure.pl.
This patch addresses that issue.