Selector Signal Interoperability. #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
commented
Nov 13, 2016
| IMP impl = method_getImplementation(method); | ||
|
|
||
| if (impl != _objc_msgForward) { | ||
| class_replaceMethod(object_getClass(self), aliasSelector, impl, method_getTypeEncoding(method)); |
There was a problem hiding this comment.
This looks nasty, but there is no other reliable way to invoke a specific IMP with NSInvocation in the standard toolbox.
|
Hmm, not ready yet. Had a problem with KVO.
|
andersio
force-pushed
the
selector-signal-interop
branch
from
b745261 to
84aa0a4
Compare
This was referenced Nov 16, 2016
# Conflicts: # .travis.yml
Swift PR: ReactiveCocoa/ReactiveCocoa#3302 1. Improved performance in general method interception. 2. Reduced the overhead of computing selector aliases. 3. Reliable invocation of the next implementation of `-forwardInvocation:`, `-methodSignatureForSelector:` and `-respondsToSelector:` in the superclass hierarchy.
andersio
force-pushed
the
selector-signal-interop
branch
from
596b3fa to
4dac92c
Compare
This reverts commit 83f16d5.
|
What's the state of this PR? |
|
@sprynmr Still working in testing progress |
|
Gonna port back a few changes from the Swift version. |
byohay
pushed a commit
to byohay/ReactiveObjC
that referenced
this pull request
Dec 14, 2021
…-latest-complete-if-no-inner-signal-is-sent RACSignal+Operations: make -switchToLatest complete in all scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included test cases from #27.
Terminology
Stated class: The class the instance meant to be at compile time.
Runtime subclass: The subclass of the perceived class created at runtime.
Summary
RAC now respects any further swizzling of
forwardInvocation:,responseToSelector:and method implementations made to the stated class.The PR also fixed a bug that caused an unrecognised selector exception when calling a setter that has been swizzled by KVO and subsequently by RAC.
Implementation Notes
Before the PR, RAC grabs the IMP of any selector by searching through the inheritance hierarchy, and aliases it or preserves it before replacing the IMP with
_objc_msgForwardor its custom implementation.After the PR, RAC generally does not alias any IMP, and relies on the ObjC runtime at the call time to resolve & call the method with an IMP swapping trick.
What's not solved
Interoperability with frameworks (except Cocoa KVO) that isa-swizzle an instance and provide custom implementations for the following selectors in the runtime subclass:
forwardInvocation:,methodSignatureForSelector:, andrespondsToSelector:.Related: ReactiveCocoa/ReactiveCocoa#1561