Headings Hiearchy Fixed #2443
Open
Headings Hiearchy Fixed #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVarchuk
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Hi @shubhamt619, thank you for your contribution.
I have a couple of questions/clarifications
| @@ -41,7 +47,7 @@ export const RightPanelHeader = styled.h3` | |||
| ${extensionsHook('RightPanelHeader')}; | |||
| `; | |||
|
|
|||
| export const UnderlinedHeader = styled.h5` | |||
| export const UnderlinedHeader = styled.h4` | |||
There was a problem hiding this comment.
why do we need to change h5->h4?
| @@ -36,7 +36,7 @@ export const Operation = observer(({ operation }: OperationProps): JSX.Element = | |||
| {options => ( | |||
| <Row {...{ [SECTION_ATTR]: operation.operationHash }} id={operation.operationHash}> | |||
| <MiddlePanel> | |||
| <H2> | |||
| <H3> | |||
There was a problem hiding this comment.
Is it necessary to change level of heading in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Headings Hierarchy was missing tags.
Added keyboard navigation to Headings
Fixed #2408
Fixed #2405
Reference
Refer to #2408
Refer to #2405
Tests
All test cases passed, because I updated the test cases where needed.
Screenshots (optional)
Check yourself