New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better bounds check #33

Merged

kuszmaul merged 1 commit into RelationalAI-oss:main from kuszmaul:bck-better-bounds-check

Nov 5, 2024

Contributor

kuszmaul commented Oct 29, 2024

To get bounds checking, the current code relies on the boundscheck function getting inlined.

It should be enough to get the getindex (or setindex!) function inlined. So those functions should declare the @boundscheck.

Move the @boundscheck declaration to getindex and setindex!.


          Make the @BoundsCheck optimization not rely on inlining the boundsche…

…ck function

NHDaly approved these changes

View reviewed changes

Member

NHDaly left a comment

+1 this looks much better to me. 👍

Have you checked the RAI microbenchmarks on this?

kuszmaul merged commit dd10a13 into RelationalAI-oss:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet