Correct handling of None in TupleNode + Extended support from typing.List to typing.Iterable #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct handling of None in TupleNode: Fixes #62.
You might wish to add corresponding unit tests:
This should not raise an error anymore:
While this should continue to raise an error as usual:
Extended support from typing.List to typing.Iterable (and Dict to Mapping)
Fixes #52, Fixes #51, fixes #47.
You might wish to include the following basic tests:
Note: the fix with Iterable can probably fail in some rare cases where users define a custom typing.GenericMeta type inheriting from typing.Iterable BUT having several inner generic arguments (like it is in typing.Mapping, that we currently handle correctly by handling it BEFORE other Iterables). Not sure that this case will happen soon :)