Configure SUMA product tree base URL #1264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adnilson
approved these changes
Dec 23, 2024
Allow user to configure the SUMA product tree base URL in RMT's config file `mirroring.suma_product_tree_base_url` attribute. The configured value takes precedence over the default (https://scc.suse.com/suma/).
lcaparroz
force-pushed
the
custom-suma-tree-url
branch
from
74efdd1 to
db348c0
Compare
digitaltom
reviewed
Dec 23, 2024
| @mirroring_base_dir = mirroring_base_dir | ||
| @url = url | ||
| @url = url || Settings.try(:mirroring).try(:suma_product_tree_base_url) || FILE_URL |
There was a problem hiding this comment.
Is the url to load the product tree from different than the scc host from the config?
There was a problem hiding this comment.
That is a good question.
Wouldn't the config/rmt.yml file have something like this below?
mirroring: suma_product_tree_base_url: <%= ENV['SUMA_URL'] %>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow user to configure the SUMA product tree base URL in RMT's config file
mirroring.suma_product_tree_base_urlattribute. The configured value takes precedence over the default (https://scc.suse.com/suma/).How to test
On your local setup, change the attribute
mirroring.suma_product_tree_base_urlonconfig/rmt.local.ymlto point to a custom URL (the URL must be reachable and respond to<custom URL>/product_tree.json, e.g.:Then, run
bin/rmt-cli mirror, and verify that the log output shows that the mirroring process has finished without any errors regarding the SUMA product tree.Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.