Improve Motor GenericReference field #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the delay. I agree with this change. I pushed a branch where I tried this on https://github.com/Scille/umongo/tree/reference_cls Do you think you could rework your PR to include those changes and add unit tests? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a
NotImpletementedexception when using.fetchon a generic reference field. This commit fixes the problem. I have a workaround, by declaring the reference_cls attribute explicitly in my own code,GenericReferenceField(reference_cls=MotorAsyncIOReference), but it seemed like a change I should submit upstream.I noticed a related issue #349, so I'm trying to make this commit compatible.
What do you think?