Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci/autogpt_libs): Add CI pipeline for autogpt_libs #8764

Closed
wants to merge 6 commits into from

Conversation

aarushik93
Copy link
Contributor

We've never had any CI for autogpt_libs and no linter or formatting going on in this folder. This PR fixes that.

Changes 🏗️

Added a scripts.py in autogpt_libs, which contains the lint function and the format function
Added a new GHA workflow specifically for autogpt_libs to run on PRs and merge to dev and master
Ran the formatter and linter on autogpt_libs - which formatted existing files, hence the extra changes.

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@aarushik93 aarushik93 requested review from a team as code owners November 25, 2024 22:48
@aarushik93 aarushik93 requested review from ntindle and Pwuts and removed request for a team November 25, 2024 22:48
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/l labels Nov 25, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Error Handling
The format() function lacks error handling and logging compared to lint(). Consider adding try-catch block and error reporting for consistency.

Exit Code
The ruff check command uses --exit-zero flag which prevents failing on errors, potentially masking linting issues

Code Smell
The generate_api_key method creates an APIKeyContainer but the code formatting suggests incomplete initialization of all required fields

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit b8df9a1
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/674501a48218470008354f97

@aarushik93 aarushik93 closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant