-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Chrome on Android #130
base: master
Are you sure you want to change the base?
Conversation
@abrichr Has this been fixed since you posted the issue? I was panning on using this project on Chrome on Android. |
@vincentmorneau I haven't been keeping up with this project since I created this PR. Since it hasn't been merged or closed, and a search for It does work using this PR however. I believe the reason that it has not been merged is because I haven't added any tests (as per https://github.com/TalAter/annyang/blob/master/CONTRIBUTING.md#automated-testing). Try it out and let me know how it goes! |
@abrichr Firstly, Thanks for the PR on this Android chrome. 👍 As per my experience with Android. The problem are:
But this fix is again restarting with a time check. The main issue here is again: a. User is getting irritated with those beep sounds of 'On' & 'Off' Can you please tell if these issues were fixed in your PR? |
Can confirm. I had to turn down my phone's device volume to get rid of the nagging microphone ping. |
The only time I have used getUserMedia for the mic on an android device and not received a beeping is when using the Mumble Web Client. I presume that this has to do with the fact that it is running through Node.JS. I just requested more info from the developer to see if he knows how to get around this. |
This PR implements workarounds for two bugs in SpeechRecognition in Chrome on Android:
SpeechRecognition.maxAlternatives
is not respected; 5 alternatives are returned regardless of the attribute value.SpeechRecognition.onend()
is called, an extraSpeechRecognitionResultEvent
is triggered whoseresults
attribute contains aSpeechRecognitionResultList
in which thetranscript
of eachitem
is the concatenation oftranscript
s of seemingly random positions in theSpeechRecognitionResultList
s seen since the last time.start()
was called. For example: