Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes join.py and split.py action and requirements error #12438

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
beautifulsoup4
fake_useragent
fake-useragent
imageio
keras
lxml
Expand All @@ -11,7 +11,7 @@ pillow
requests
rich
scikit-learn
sphinx_pyproject
sphinx-pyproject
statsmodels
sympy
tweepy
Expand Down
62 changes: 19 additions & 43 deletions strings/join.py
Original file line number Diff line number Diff line change
@@ -1,51 +1,27 @@
"""
Program to join a list of strings with a separator
"""


def join(separator: str, separated: list[str]) -> str:
"""
Joins a list of strings using a separator
and returns the result.

:param separator: Separator to be used
for joining the strings.
:param separated: List of strings to be joined.

:return: Joined string with the specified separator.

Examples:

>>> join("", ["a", "b", "c", "d"])
'abcd'
Copy link

@Kaaserne Kaaserne Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason these got removed? I've never used doctest before but I think this has something to do with testing. Maybe you can also add:

"""
>>> join(',', ['', '', ''])
',,'
"""

>>> join("#", ["a", "b", "c", "d"])
'a#b#c#d'
>>> join("#", "a")
'a'
>>> join(" ", ["You", "are", "amazing!"])
'You are amazing!'

This example should raise an
exception for non-string elements:
>>> join("#", ["a", "b", "c", 1])
Traceback (most recent call last):
...
Exception: join() accepts only strings

Additional test case with a different separator:
>>> join("-", ["apple", "banana", "cherry"])
'apple-banana-cherry'
Custom implementation of the join() function.
This function manually concatenates the strings in the list,
using the provided separator, without relying on str.join().

:param separator: The separator to place between strings.
:param separated: A list of strings to join.

:return: A single string with elements joined by the separator.

:raises Exception: If any element in the list is not a string.
"""
if not all(isinstance(word_or_phrase, str) for word_or_phrase in separated):
raise Exception("join() accepts only strings")
Copy link

@Kaaserne Kaaserne Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this if statement, with the removal of all, can be placed inside the for-loop. That way we only iterate over the sequence once, instead of twice.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your advice. sure lemme check


joined = ""
for word_or_phrase in separated:
if not isinstance(word_or_phrase, str):
raise Exception("join() accepts only strings")
joined += word_or_phrase + separator
# Manually handle concatenation
result = ""
for i, element in enumerate(separated):
result += element
if i < len(separated) - 1: # Add separator only between elements
result += separator

# Remove the trailing separator
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kaaserne can you please review it?

# by stripping it from the result
return joined.strip(separator)
return result


if __name__ == "__main__":
Expand Down
17 changes: 13 additions & 4 deletions strings/split.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,23 @@ def split(string: str, separator: str = " ") -> list:
"""

split_words = []

last_index = 0

for index, char in enumerate(string):
if char == separator:
split_words.append(string[last_index:index])
split_words.append(
string[last_index:index]
) # Add substring between separators
last_index = index + 1
elif index + 1 == len(string):
split_words.append(string[last_index : index + 1])
elif index + 1 == len(
string
): # If at the last character, handle trailing separator
split_words.append(string[last_index:]) # Add the last part of the string

# If the string ends with a separator, ensure an empty string is added
if string and string[-1] == separator:
split_words.append("")

return split_words


Expand Down
Loading