Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional doctests, fix grammatical errors for maths/perfect_number.py #12477

Merged
merged 4 commits into from
Dec 28, 2024
Merged

Add additional doctests, fix grammatical errors for maths/perfect_number.py #12477

merged 4 commits into from
Dec 28, 2024
+14 −5

Conversation

joy-programs
Copy link
Contributor

Describe your change:

Contributes to #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@joy-programs joy-programs changed the title Add additional doctests for maths/perfect_number.py algorithm and fix grammatical errors. #9943 Add additional doctests for maths/perfect_number.py algorithm and fix grammatical errors. Dec 27, 2024
@joy-programs joy-programs changed the title Add additional doctests for maths/perfect_number.py algorithm and fix grammatical errors. Add additional doctests and fix grammatical errors for maths/perfect_number.py algorithm. Dec 27, 2024
@joy-programs joy-programs changed the title Add additional doctests and fix grammatical errors for maths/perfect_number.py algorithm. Add additional doctests and fix grammatical errors for maths/perfect_number.py. Dec 27, 2024
@joy-programs joy-programs changed the title Add additional doctests and fix grammatical errors for maths/perfect_number.py. Add additional doctests and fix grammatical errors for maths/perfect_number.py Dec 27, 2024
@joy-programs joy-programs changed the title Add additional doctests and fix grammatical errors for maths/perfect_number.py Add additional doctests, fix grammatical errors for maths/perfect_number.py Dec 27, 2024
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Dec 27, 2024
@joy-programs
Copy link
Contributor Author

@cclauss please review

tianyizheng02
tianyizheng02 approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your improvements!

maths/perfect_number.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Dec 28, 2024
@tianyizheng02 tianyizheng02 merged commit b5c8fbf into TheAlgorithms:master Dec 28, 2024
5 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joy-programs @tianyizheng02