Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements for recognize_assemblyai() method: #706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrickloeber
Copy link

Hi, I made some fixes and improvements for the recognize_assemblyai() method, since it was only working with a file path before and didn't have correct error handling:

  • Adds support for AudioData instance. Before, it only worked with a path to a file
  • Adds more error handling
  • Removes inner read_file function since the requests module automatically handles chunking
  • Removes "content-type" from header since this is not needed
  • Adds docstring
  • Adds example code snippet in examples/audio_transcribe.py
  • Lists AssemblyAI in README

- Adds support for `AudioData` instance.
  Before, it only worked with a path to a file
- Add more error handling
- Removes inner `read_file` function since the requests module
  automatically handles chunking
- Removes "content-type" from header since this is not needed
- Add docstring
- Add example code snippet in `examples/audio_transcribe.py`
- List AssemblyAI in README
@ftnext ftnext added this to the 3.11 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants