-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set hd and hdrp-blank templates to use Input System exclusively in 6000.1 [ISX-2217] #8118
base: master
Are you sure you want to change the base?
Set hd and hdrp-blank templates to use Input System exclusively in 6000.1 [ISX-2217] #8118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see input system version updated and set to Input System only
I see there are input action assets already present in the projects
Was slightly surprised the input system package dependency was missing for hdrp-blank given that there was the input action asset in the project.
Note this is related to task https://jira.unity3d.com/browse/ISX-2217
Which is related to this Epic https://jira.unity3d.com/browse/ISX-2214
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On reflection I think its the manifest.json file that also needs changing. Not just the package.json file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the more comprehensive update with changelogs and version updates
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*
label. After you backport the PR, the label changes tobackported-*
.CHANGELOG.md
file.Purpose of this PR
There's a drive for better Input System adoption in 6000.1 and one way we're doing this is by updating key templates. All this PR does is change the input backend to Input System exclusive and adds a dependency for it.
Testing status
Ran every available scene looking for unexpected issues. The third person controller in the hd template already uses Input System so that worked fine out of the box
Comments to reviewers
Do note that this is going into the master branch. I don't know how to target the 6.1 Editor only 😅 I believe the graphics team will handle landing though