Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hd and hdrp-blank templates to use Input System exclusively in 6000.1 [ISX-2217] #8118

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Pauliusd01
Copy link

@Pauliusd01 Pauliusd01 commented Dec 19, 2024

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

There's a drive for better Input System adoption in 6000.1 and one way we're doing this is by updating key templates. All this PR does is change the input backend to Input System exclusive and adds a dependency for it.


Testing status

Ran every available scene looking for unexpected issues. The third person controller in the hd template already uses Input System so that worked fine out of the box


Comments to reviewers

Do note that this is going into the master branch. I don't know how to target the 6.1 Editor only 😅 I believe the graphics team will handle landing though

@Pauliusd01 Pauliusd01 changed the title Switch input backend to input system exclusive TBD Set hd and hdrp-blank templates to use Input System Exclusively [ISX-2217] Dec 19, 2024
@Pauliusd01 Pauliusd01 changed the title Set hd and hdrp-blank templates to use Input System Exclusively [ISX-2217] Set hd and hdrp-blank templates to use Input System exclusively in 6000.1 [ISX-2217] Dec 19, 2024
Copy link

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see input system version updated and set to Input System only

I see there are input action assets already present in the projects
Was slightly surprised the input system package dependency was missing for hdrp-blank given that there was the input action asset in the project.

Note this is related to task https://jira.unity3d.com/browse/ISX-2217
Which is related to this Epic https://jira.unity3d.com/browse/ISX-2214

Copy link

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On reflection I think its the manifest.json file that also needs changing. Not just the package.json file

Copy link

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the more comprehensive update with changelogs and version updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants