Add convexity and inertia ratio to findBlobs #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLLeitschuh
reviewed
Mar 25, 2019
| @@ -66,6 +74,8 @@ public FindBlobsOperation(InputSocket.Factory inputSocketFactory, OutputSocket.F | |||
| inputSocket, | |||
| minAreaSocket, | |||
| circularitySocket, | |||
| convexitySocket, | |||
| inertiaRatioSocket, | |||
There was a problem hiding this comment.
Unfortunately, if you don't put these last, you'll break deserializing older save files. Save files are order dependent.
There was a problem hiding this comment.
Ah gotcha, thanks for the heads up for the future.
JLLeitschuh
reviewed
Mar 25, 2019
| private final SocketHint<List<Number>> convexityHint = SocketHints.Inputs | ||
| .createNumberListRangeSocketHint("Convexity", 0.0, 1.0); | ||
| private final SocketHint<List<Number>> inertiaRatioHint = SocketHints.Inputs | ||
| .createNumberListRangeSocketHint("Inertia Ratio", 0.0, 1.0); | ||
| private final SocketHint<Boolean> colorHint = SocketHints | ||
| .createBooleanSocketHint("Dark Blobs", false); |
There was a problem hiding this comment.
@SamCarlberg At some point, we should come back through here and make all these static.
JLLeitschuh
reviewed
Mar 25, 2019
| @@ -44,6 +48,8 @@ | |||
| private final InputSocket<Mat> inputSocket; | |||
| private final InputSocket<Number> minAreaSocket; | |||
| private final InputSocket<List<Number>> circularitySocket; | |||
| private final InputSocket<List<Number>> convexitySocket; | |||
| private final InputSocket<List<Number>> inertiaRatioSocket; | |||
| private final InputSocket<Boolean> colorSocket; | |||
There was a problem hiding this comment.
Nitpick, can you put these in the same order as they are declared in the getInputSockets method, same thing about their declaration in the constructor and in the socket hints list.
|
@SamCarlberg Feel free to merge if you also approve. |
TheTripleV
force-pushed
the
update_find_blobs
branch
from
5f1ae35 to
098fb03
Compare
|
CC: @SamCarlberg |
|
Would you be willing to rebase this change? I'm happy to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #880
Adds Sliders for convexity and inertia ratio.
