Allow admin pages

[aristath]

Possible fix for #254

[jrfnl]

The Tests/PluginTerritory/NoAddAdminPagesUnitTest.php file has not been adjusted which is why the tests are failing.

[dingo-d]

I kinda think that Travis is failing due to all the changes on develop branch of WPCS 😬

[pattonwebz]

We probably want to pin a specific version of phpcs then.

[dingo-d]

It's not because of PHPCS, it's because of WPCS. There is an effort to rewrite tons of it using new awesome utils written by @jrfnl. Not 100% sure why it fails, will probably have to look at it in depth when I have the time.

[jrfnl]

@dingo-d I already checked, some of the utilities from WPCS which have been removed are used in sniffs here, that's why. Also with PHPCSUtils in alpha, minimum stability is an issue.

As for updating the Travis script - either fix it to WPCS dev-master instead of dev-develop as "high" version, or considering that there's not that much activity in this repo, leave it for the time being and fix it by upgrading to WPCS 3.0/PHPCSUtils for the next version.

I started updating the Travis script last week and then didn't pull it with the above in mind, but if you like I can pull it anyway.

[dingo-d]

I mean if it solves the current problem then you can update Travis script. But this is actually an excellent opportunity to start using utils here 🙂

[jrfnl]

I mean if it solves the current problem then you can update Travis script. But this is actually an excellent opportunity to start using utils here

@dingo-d Those two things are unrelated.

We can start using PHPCSUtils already, but that wouldn't automatically solve the build failure for WPCS dev-develop as sniffs have been removed etc

So, upgrading to WPCS 3.0.0 and starting to use PHPCSUtils are two different "projects", though they can be done at the same time, in which case it will be easiest to do so once WPCS 3.0.0 is in RC and it is clear what has changed.

Considering there is still plenty to be done for WPCS and PHPCompatibility at the moment, I'm not keen to take on a third such project concurrently, but feel free to get started yourself ;-)

[dingo-d]

Oh I was thinking of doing this myself (a separate task ofc) ^^

[dingo-d]

@aristath We have moved away from Travis to GH actions for CI checks. Can you rebase your PR so that we may see if the checks will pass?

[aristath]

Done 👍

[dingo-d]

All the tests are passing so I think it's ok to merge.

[jrfnl]

Aside from the sniff class docblock still needing to be updated, this largely seems to address #254.

Two concerns:

1. From the discussion in Allow add_menu_page & add_submenu_page #254, I get the (possibly incorrect) impression that theme admin page additions should be limited to max one top-level item, but that multiple sub-level items are allowed.
   This PR does not enforce that.
2. From the discussion in Allow add_menu_page & add_submenu_page #254, I get the impression that there was no consensus about the issue.
   Not sure whether that has been resolved in the mean time. Might be a good idea to document in the issue if and when this was discussed again (in Slack or elsewhere) and whether there was consensus in any later discussions.