Build: Simplify tsconfig.json files #68326
Conversation
sirreal
requested review from
kevin940726,
ellatrix,
gziolo,
adamsilverstein,
swissspidy,
ajitbohra,
ntwb,
nerrad,
luisherranz,
DAreRodz,
dmsnell,
fabiankaegy and
mmtr
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| ); | ||
| } catch ( e ) { | ||
| console.error( | ||
| `Error parsing package.json for package ${ packageName }` |
There was a problem hiding this comment.
Thank you for handling errors here.
|
Flaky tests detected in 8f4b91b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12506387253
|
| @@ -1,10 +1,5 @@ | |||
| { | |||
| "$schema": "https://json.schemastore.org/tsconfig.json", | |||
There was a problem hiding this comment.
While we are here, why do we need this "$schema" in ever tsconfig.json file? Don't the IDEs and TS automatically infer that?
There was a problem hiding this comment.
I see that it was added in #59861
There was a problem hiding this comment.
Some might infer it based on the filename, but including it ensures that supporting environments will use the appropriate schema. There's little downside to including it and the benefits are significant.
|
We need to fix |
|
I have created #68346 following this one. |
What?
Simplify tsconfig.json files. TypeScript 5.5 introduced a
configDirvariable that can be used for templating tsconfig.json files. This can vastly reduce repitition in tsconfig.json files.srcinstead ofsrc/**/*).Why?
This removes a lot of repetition from tsconfig.json files.
Testing Instructions
CI passes. TSC should continue to work as expected locally.