DropdownMenu: Deprecate 36px default size for toggle button #68329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
|
Size Change: +231 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
This was referenced Dec 26, 2024
mirka
added
the
Needs Dev Note
|
Flaky tests detected in 3d56175. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12508929385
|
mirka
commented
Dec 26, 2024
| @@ -67,7 +67,7 @@ exports[`AlignmentUI should match snapshot when controls are hidden 1`] = ` | |||
| aria-expanded="false" | |||
| aria-haspopup="true" | |||
| aria-label="Align text" | |||
| class="components-button components-dropdown-menu__toggle has-icon" | |||
| class="components-button components-dropdown-menu__toggle is-compact has-icon" | |||
| @@ -10,7 +10,7 @@ exports[`BlockAlignmentUI should match snapshot when controls are hidden 1`] = ` | |||
| aria-expanded="false" | |||
| aria-haspopup="true" | |||
| aria-label="Align" | |||
| class="components-button components-dropdown-menu__toggle has-icon" | |||
| class="components-button components-dropdown-menu__toggle is-compact has-icon" | |||
| @@ -18,7 +18,7 @@ export function BlockSettingsMenu( { clientIds, ...props } ) { | |||
| { ( toggleProps ) => ( | |||
| <BlockSettingsDropdown | |||
| clientIds={ clientIds } | |||
| toggleProps={ toggleProps } | |||
| toggleProps={ { ...toggleProps, size: 'compact' } } | |||
There was a problem hiding this comment.
In some instances, like here, we'll override the size coming from the current toggleProps.
In others, we'll prioritize the user value:
Is there a reason for this discrepancy, and should we treat them consistently?
| @@ -334,6 +334,7 @@ export const BlockSwitcher = ( { clientIds } ) => { | |||
| } | |||
| text={ blockIndicatorText } | |||
| toggleProps={ { | |||
| size: 'compact', | |||
| @@ -10,7 +10,7 @@ exports[`BlockVerticalAlignmentUI should match snapshot when controls are hidden | |||
| aria-expanded="false" | |||
| aria-haspopup="true" | |||
| aria-label="Change vertical alignment" | |||
| class="components-button components-dropdown-menu__toggle has-icon" | |||
| class="components-button components-dropdown-menu__toggle is-compact has-icon" | |||
Comment on lines
+40
to
+43
| toggleProps={ { | ||
| size: 'compact', | ||
| ...toolbarItemProps, | ||
| } } |
There was a problem hiding this comment.
As seen in the default Storybook story:
| @@ -28,6 +28,7 @@ function ToolbarGroupCollapsed( { | |||
| controls={ controls } | |||
| toggleProps={ { | |||
| ...internalToggleProps, | |||
| size: 'compact', | |||
There was a problem hiding this comment.
As seen in the default Storybook story:
| @@ -120,6 +132,9 @@ function UnconnectedDropdownMenu( dropdownMenuProps: DropdownMenuProps ) { | |||
| return ( | |||
| <Toggle | |||
| { ...mergedToggleProps } | |||
| { ...( toggleProps?.as === undefined | |||
| ? { __shouldNotWarnDeprecated36pxSize: true } | |||
There was a problem hiding this comment.
This is to prevent a redundant warning from Button when DropdownMenu has already warned.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
25 tasks
tyxla
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Did we miss to address a few instances, or is that intentional?
gutenberg/packages/block-library/src/image/image.js
Lines 125 to 128 in 20a9a81
gutenberg/packages/block-library/src/navigation/edit/leaf-more-menu.js
Lines 117 to 124 in 20a9a81
gutenberg/packages/components/src/tabs/stories/index.story.tsx
Lines 405 to 424 in eb01c74
gutenberg/packages/components/src/toolbar/toolbar-item/README.md
Lines 37 to 42 in 5c7f039
gutenberg/packages/editor/src/components/collab-sidebar/comments.js
Lines 281 to 289 in eb01c74
gutenberg/packages/preferences/README.md
Line 144 in 5c7f039
I suppose we intentionally skipped these with a different prior size:
gutenberg/packages/components/src/palette-edit/index.tsx
Lines 489 to 499 in 20a9a81
or a specific variant:
gutenberg/packages/edit-site/src/components/add-new-pattern/index.js
Lines 126 to 130 in eb01c74
Finally, I guess we don't need to add these props to the component tests?
| @@ -18,7 +18,7 @@ export function BlockSettingsMenu( { clientIds, ...props } ) { | |||
| { ( toggleProps ) => ( | |||
| <BlockSettingsDropdown | |||
| clientIds={ clientIds } | |||
| toggleProps={ toggleProps } | |||
| toggleProps={ { ...toggleProps, size: 'compact' } } | |||
There was a problem hiding this comment.
In some instances, like here, we'll override the size coming from the current toggleProps.
In others, we'll prioritize the user value:
Is there a reason for this discrepancy, and should we treat them consistently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65751
Stacked on #68328
What?
Deprecate the 36px default size on default toggle button for DropdownMenu.
Also updates the consumers so they don't log warnings.
Testing Instructions
__next40pxDefaultSizeprop enabled