Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block theme: Test custom CSS behaviour #8025

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

Block theme: Test custom CSS behaviour #8025

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
577309f
Block theme: Test custom CSS behaviour
mukeshpanchal27 Dec 19, 2024
cafedb0
Temp revert deprecated function changes
mukeshpanchal27 Dec 19, 2024
70a4a9f
Remove version condition
mukeshpanchal27 Dec 19, 2024
e2ec906
Fix PHPCS
mukeshpanchal27 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/wp-includes/class-wp-theme-json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,12 +1497,10 @@ protected function process_blocks_custom_css( $css, $selector ) {
* Returns the global styles custom CSS.
*
* @since 6.2.0
* @deprecated 6.7.0 Use {@see 'get_stylesheet'} instead.
*
* @return string The global styles custom CSS.
*/
public function get_custom_css() {
_deprecated_function( __METHOD__, '6.7.0', 'get_stylesheet' );
// Add the global styles root CSS.
$stylesheet = isset( $this->theme_json['styles']['css'] ) ? $this->theme_json['styles']['css'] : '';

Expand Down
24 changes: 24 additions & 0 deletions tests/phpunit/tests/theme/wpThemeJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6119,4 +6119,28 @@

$this->assertSame( $expected, $button_variations );
}

public function test_custom_css_behaviour() {
$theme_json = new WP_Theme_JSON(
array(
'version' => WP_Theme_JSON::LATEST_SCHEMA,
'styles' => array(
'css' => 'body {color:purple;}',
'blocks' => array(
'core/paragraph' => array(
'css' => 'color:red;',
),
),
),
)
);

$custom_css = 'body {color:purple;}';
$block_custom_css = ':root :where(p){color:red;}';

// get_custom_css() should return both CSS.
$this->assertSame( $custom_css . $block_custom_css, $theme_json->get_custom_css() );
// Per #6750, The get_stylesheet() returns only $custom_css.

Check failure on line 6143 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards / Run coding standards checks 

Whitespace found at end of line
mukeshpanchal27 marked this conversation as resolved.
Show resolved Hide resolved
$this->assertSame( $custom_css . $block_custom_css, $theme_json->get_stylesheet( array( 'custom-css' ) ) );
}
}
Loading