-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update $network_id Parameter Type to int|null for Network Option Methods #8038
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
I also confirmed that int|null has been used in other functions, such as wordpress-develop/src/wp-includes/ms-functions.php Lines 103 to 117 in dc9b16b
|
src/wp-includes/option.php
Outdated
* @param mixed $serialized_value The serialized value of the option to check its autoload value. | ||
* @param bool|null $autoload The autoload value to check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param mixed $serialized_value The serialized value of the option to check its autoload value. | |
* @param bool|null $autoload The autoload value to check. | |
* @param mixed $serialized_value The serialized value of the option to check its autoload value. | |
* @param bool|null $autoload The autoload value to check. |
Alignments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mukeshpanchal27, thanks for the review. I have fixed the alignment issue; please check again.
This PR updates the documented type of the $network_id parameter in
get_network_option
,update_network_option
, anddelete_network_option
methods to int|null, reflecting that NULL can be passed to default to the current network ID.Trac ticket: https://core.trac.wordpress.org/ticket/62735