Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mijn.host DNS challenge #5287

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

shubhamku044
Copy link

No description provided.

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@shubhamku044
Copy link
Author

I am getting this response
image

@shubhamku044
Copy link
Author

Now i am successfully able to generate the certificate

image(2)

@mijnhost
Copy link

mijnhost commented Oct 7, 2024

@Neilpang do you have time to review this PR?

@Neilpang
Copy link
Member

Neilpang commented Oct 7, 2024

@ualex73
Copy link

ualex73 commented Dec 8, 2024

Any progress on this?

@peterv99
Copy link

peterv99 commented Dec 11, 2024

I guess you need to enable Github Actions on your Forked repo first, and then push code to your repo, it will run there. Like the page states. I'd like to see mijn.host added as well, so I appreciate your efforts.

@ualex73
Copy link

ualex73 commented Dec 12, 2024

@shubhamku044 can you follow up on this ?

@shubhamku044
Copy link
Author

Is it done? @ualex73
I was planning to finish it this weekend

@peterv99
Copy link

Nope. Tests run but fail. Not sure why, since your script is fine standalone. I've asked for a bit of support in my pull request.

@ualex73
Copy link

ualex73 commented Dec 19, 2024

Is it done? @ualex73 I was planning to finish it this weekend

No, I was not working on this. I just like to see it included, then I can switch to mijn.host with my domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants