Migrate from rollup to rolldown #3578
Open
+47
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3578 +/- ##
==========================================
+ Coverage 89.75% 91.06% +1.30%
==========================================
Files 48 48
Lines 3457 3457
Branches 653 672 +19
==========================================
+ Hits 3103 3148 +45
+ Misses 354 309 -45 |
|
@amanmahajan7 rolldown seems to work great now! |
| @@ -55,21 +55,14 @@ | |||
| "clsx": "^2.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/core": "^7.26.0", | |||
| "skipLibCheck": true | ||
| }, | ||
| "include": ["**/*.js", ".github/**/*.js"], | ||
| "include": ["**/*.js", ".github/**/*.js", "package.json"], |
There was a problem hiding this comment.
Why do we include package.json?
There was a problem hiding this comment.
rolldown.config.js imports it, and we typecheck it (via // @ts-check), so the file must be included for typechecking to work correctly.
Otherwise:
File 'd:/repos/react-data-grid/package.json' is not listed within the file list of project 'd:/repos/react-data-grid/tsconfig.js.json'. Projects must list all files or use an 'include' pattern.
rolldown.config.js
Outdated
| export default outputs.map((output) => | ||
| defineConfig({ | ||
| input: './src/index.ts', | ||
| output, |
There was a problem hiding this comment.
output cannot be an array?
There was a problem hiding this comment.
It couldn't before, it can be now. (rolldown/rolldown#3200)
I've compared the bundle output after running prettier on the output files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rolldown.rs/
https://www.npmjs.com/package/rolldown
https://github.com/rolldown/rolldown