Unit of work #498
Open
Unit of work #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
armanddidierjean
force-pushed
the
unit-of-work2
branch
from
02a3fe2 to
146dba3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
- Coverage 81.81% 81.79% -0.02%
==========================================
Files 125 126 +1
Lines 9469 9492 +23
==========================================
+ Hits 7747 7764 +17
- Misses 1722 1728 +6 ☔ View full report in Codecov by Sentry. |
armanddidierjean
requested changes
Aug 25, 2024
|
|
||
|
|
||
| async def create_flappybird_best_score( | ||
| db: AsyncSession, | ||
| db: TransactionalAsyncSession, |
There was a problem hiding this comment.
Suggested change
| db: TransactionalAsyncSession, | |
| db: AsyncSession, |
| @@ -48,33 +49,29 @@ async def get_flappybird_score_position( | |||
|
|
|||
|
|
|||
| async def create_flappybird_score( | |||
| db: AsyncSession, | |||
| db: TransactionalAsyncSession, | |||
There was a problem hiding this comment.
Suggested change
| db: TransactionalAsyncSession, | |
| db: AsyncSession, |
Comment on lines
+91
to
+92
| # The use of transactional database requires the use of NullPool as it implies the use of a db in multiple run loops | ||
| # https://docs.sqlalchemy.org/en/14/orm/extensions/asyncio.html#using-multiple-asyncio-event-loops |
There was a problem hiding this comment.
We need to clear the usage of NullPool up. This should not break tests as this dependency should not be called during tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist