Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raid issues #596

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

fix: Raid issues #596

wants to merge 16 commits into from

Conversation

maximeroucher
Copy link
Member

  • Fix team number

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.69%. Comparing base (02b2463) to head (88bad4a).

Files with missing lines Patch % Lines
app/modules/raid/cruds_raid.py 25.00% 3 Missing ⚠️
app/modules/raid/utils/utils_raid.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   81.54%   81.69%   +0.15%     
==========================================
  Files         128      128              
  Lines        9928     9934       +6     
==========================================
+ Hits         8096     8116      +20     
+ Misses       1832     1818      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@armanddidierjean armanddidierjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an unit test?

@maximeroucher
Copy link
Member Author

What do you want to test ?

@armanddidierjean
Copy link
Member

I think set_team_number is never called by the test, it is not covered

tests/test_raid.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants