Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore RedisConnectionError and exclude TypeChecking blocks from coverage #620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

armanddidierjean
Copy link
Member

No description provided.

@armanddidierjean armanddidierjean added enhancement New feature or request test Improve test coverage labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (08dcf2b) to head (12e6b44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   81.26%   81.28%   +0.01%     
==========================================
  Files         128      128              
  Lines        9949     9937      -12     
==========================================
- Hits         8085     8077       -8     
+ Misses       1864     1860       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Daihecyy

This comment was marked as duplicate.

Copy link
Contributor

@Daihecyy Daihecyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing xfail to skipif since the tests seem to be expected to run in Github actions.
Maybe create a shareable skipif decorator in test_commons ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Improve test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants