Jinja templating #629
Open
Jinja templating #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 81.24% 81.31% +0.06%
==========================================
Files 128 129 +1
Lines 9950 10013 +63
==========================================
+ Hits 8084 8142 +58
- Misses 1866 1871 +5 ☔ View full report in Codecov by Sentry. |
Marc-Andrieu
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Really nice refactoring!
I could argue on some rewritings of the English translations which you made while you were at it (why not having a separate PR for that? that's not the point of this PR).
But I won't bother you on it for now (on this PR at least!), bc I'd like it to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed email templates to use a Jinja base template, created a python helper function to test the templates and improved phrasing