Sync group with association's membership #631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 81.31% 81.35% +0.04%
==========================================
Files 129 129
Lines 10013 10030 +17
==========================================
+ Hits 8142 8160 +18
+ Misses 1871 1870 -1 ☔ View full report in Codecov by Sentry. |
armanddidierjean
requested changes
Dec 14, 2024
Comment on lines
+342
to
+347
| membership_db = models_core.CoreMembership( | ||
| user_id=member.user_id, | ||
| group_id=group_id, | ||
| description="", | ||
| ) | ||
| await cruds_groups.create_membership(db=db, membership=membership_db) |
There was a problem hiding this comment.
You can use a bulk insert operation
https://docs.sqlalchemy.org/en/20/orm/queryguide/dml.html#orm-queryguide-bulk-insert
| @@ -304,3 +305,43 @@ async def delete_group( | |||
|
|
|||
| await cruds_groups.delete_membership_by_group_id(group_id=group_id, db=db) | |||
| await cruds_groups.delete_group(db=db, group_id=group_id) | |||
|
|
|||
|
|
|||
| @router.patch( | |||
There was a problem hiding this comment.
I think a post could be more appropriate as it start an action
|
|
||
| group_db = await cruds_groups.get_group_by_id(group_id=group_id, db=db) | ||
| if group_db is None: | ||
| raise HTTPException(status_code=404, detail="Group not found") |
There was a problem hiding this comment.
Could you test this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist