-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement product registration support #1809
Open
imobachgs
wants to merge
40
commits into
master
Choose a base branch
from
product-registration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only for testing purposes.
Actually, at this moment the flag is only used for including a link to the route in the main navigation or not depending on the Product#registration value. But the idea is to limite the navigation too in future iterations.
An initial version that basically consists on - Main menu entry for registration - Global alert visible on all pages except the registration page and those mounted at "supportive paths" (temporary name) - Section with form for entering registration code and email - Section to display registration information when available Only basic workflow has been manually tested; unit tests will be added in upcoming commits.
Certain elements must not be rendered on paths that do not use the "FullLayout". Other paths, considered "accessory" paths, have been temporarily grouped under the "SUPPORTIVE_PATHS" constant to reduce code duplication when excluding elements from them. Although the approach needs improvement, starting with the naming, let's use it where needed meanwhile.
not tested!
imobachgs
changed the title
Product registration
feat: implement product registration support
Dec 5, 2024
Pull Request Test Coverage Report for Build 12184382379Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Otherwise, it will trigger the useProduct hook which might not be available yet like in the case of the login path, in which the QueryClient has not been initialized yet.
…ct_registrion_poc_fix
Work-around issue with suse-connect cannot read credentials file.
But not rendering the link to the registration section when the user is already there. This commit also add the missing unit tests, covering all scenarios implemented until now.
To use the proper value according to the recently updated type. Basically using "no" instead of "No".
To make them work again now that it is making use of useLocation ReactRouterDom hook and to ensure it does not try to mount ProductRegistrationAlert component at certain paths.
* Promote title * Remove no longer needed hint
By using installerRender instead of plainRender when needed and pleasing TypeScript and linters.
Part of previous commit 5cd947b
For using the right value according to the type. Overlooked in previous commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This code is still a work in progress, although it already works. However, make sure to remove the SLE 15 SP6 definition because it is there just for testing purposes.
The code is included in a testing ISO you can download from OBS.
Solution
This pull request implements support for product registration. It includes changes at several levels:
/run/agama/zypp
as target directory.Testing
You can use the web UI which sends the proper request to the backend or, if you prefer, you can play around with cURL:
Set
$AGAMA_URL
to the Agama HTTP API (e.g.,https://192.168.122.10
).Screenshots