Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] bad typing for S3ArtifactStorage_clientconfig args #3276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[fix] bad typing for S3ArtifactStorage_clientconfig args #3276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aim/storage/artifacts/s3_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def _get_s3_client(self):
return client


def S3ArtifactStorage_factory(**boto3_client_kwargs: dict):
def S3ArtifactStorage_factory(**boto3_client_kwargs):
class S3ArtifactStorageCustom(S3ArtifactStorage):
def _get_s3_client(self):
import boto3
Expand All @@ -88,7 +88,7 @@ def _get_s3_client(self):
return S3ArtifactStorageCustom


def S3ArtifactStorage_clientconfig(**boto3_client_kwargs: dict):
def S3ArtifactStorage_clientconfig(**boto3_client_kwargs):
from aim.storage.artifacts import registry

registry.registry['s3'] = S3ArtifactStorage_factory(**boto3_client_kwargs)