Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop redundant items from issue template types #4551

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Feb 3, 2020

Follow-up for #4257 (comment)

@asvetlov asvetlov requested a review from webknjaz as a code owner February 3, 2020 13:01
@asvetlov

This comment has been minimized.

@@ -1,29 +1,12 @@
# Ref: https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
blank_issues_enabled: false # default: true
contact_links:
- name: 🔐 Security bug report 🔥
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably keep this because it emphasizes that people shouldn't be posting vulnerabilities in public

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open https://github.com/aio-libs/aiohttp/issues/new/choose
The third and fourth items point to the same link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunately the first one is less visible so I tend to emphasize what to do with a bigger box.

- name: 💬 Mailing list
url: https://groups.google.com/forum/#!forum/aio-libs
about: Usage Q&A
- name: 📝 Code of Conduct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is an important reminder, being visible like this it calms down people who are about to make angry postings... Also, it's important for community health because when there's a CoC in a visible place, it encourages people to consider contributing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the reference in README then.
Issue templates are for filing an issue or asking a question, not for links to informational pages (despite how these pages are important).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that people would want to file an issue about these. And we could intercept these attempts right there, when they click "New issue" they'll see that they shouldn't do this. Do you honestly think that everyone reads the docs? We both know that many people use issues tracker instead of google...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If people want they just file the issue using the first available template, we both know it.
Blowing a list of available options makes more mess than help IMHO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, do as you will

@asvetlov asvetlov merged commit cc2a178 into master Oct 15, 2020
@asvetlov asvetlov deleted the tune-issue-templates branch October 15, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants