-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract init duration #173
base: master
Are you sure you want to change the base?
Conversation
Thanks for contributing 🎉🙏
I’ll review this asap (after merging the other PR for a cleaner diff).
|
@@ -145,6 +145,11 @@ const computeStatistics = (baseCost, results, value, discardTopBottom) => { | |||
const averageDuration = utils.computeAverageDuration(durations, discardTopBottom); | |||
console.log('Average duration: ', averageDuration); | |||
|
|||
const initDurations = utils.parseLogAndExtractInitDurations(results); | |||
|
|||
const [initDuration] = initDurations; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assumption is that there's always only one cold start, right? This will change a bit when #177 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we could use the same computeAverageDuration
to get the average init duration, passing discardTopBottom
as zero.
Extract
Init Duration
from Cloudwatch logs for each power values. I pick the first value of theinitDurations
array becauseInit Duration
is present only in the first invocation.