Skip to content

Commit

Permalink
Undo recent commits on behalf of alexeymezenin
Browse files Browse the repository at this point in the history
  • Loading branch information
@spekulatius
spekulatius committed Feb 19, 2023
1 parent bad5557 commit c7e7073
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ Development Environment | Laravel Sail, Homestead | Docker
Deployment | Laravel Forge | Deployer and other solutions
Unit testing | PHPUnit, Mockery | Phpspec, Pest
Browser testing | Laravel Dusk | Codeception
ORM | Eloquent | SQL, Doctrine
DB | Eloquent | SQL, Doctrine
Templates | Blade | Twig
Working with data | Laravel collections | Arrays
Form validation | Request classes | 3rd party packages, validation in controller
Expand Down Expand Up @@ -520,7 +520,7 @@ Primary key | - | id | ~~custom_id~~
Migration | - | 2017_01_01_000000_create_articles_table | ~~2017_01_01_000000_articles~~
Method | camelCase | getAll | ~~get_all~~
Method in resource controller | [table](https://laravel.com/docs/master/controllers#resource-controllers) | store | ~~saveArticle~~
Method in test class | snake_case | test_guest_cannot_see_article | ~~testGuestCannotSeeArticle~~
Method in test class | camelCase | testGuestCannotSeeArticle | ~~test_guest_cannot_see_article~~
Variable | camelCase | $articlesWithAuthor | ~~$articles_with_author~~
Collection | descriptive, plural | $activeUsers = User::active()->get() | ~~$active, $data~~
Object | descriptive, singular | $activeUser = User::active()->first() | ~~$users, $obj~~
Expand Down

4 comments on commit c7e7073

@szepeviktor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spekulatius What is the cause here?

@alexeymezenin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szepeviktor hi and thanks for your commit.

I've asked Peter to reverse the commit. The thing is DB here means "Working with databases".

Regarding the tests naming convention. There was a huge discussion related to the issue a few years ago. The result of it was that it makes sense to stick to PSR.

@szepeviktor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your response.

@JohnnyWalkerDigital
Copy link
Contributor

@JohnnyWalkerDigital JohnnyWalkerDigital commented on c7e7073 May 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeymezenin

Regarding the tests naming convention. There was a huge discussion related to the issue a few years ago. The result of it was that it makes sense to stick to PSR.

Edit: Ah. Here is the discussion: #28 You can see the reasoning was that Laravel docs use camelCase is no longer true. Laravel officially made the change to snake_case for test methods over two years ago.

I believe @szepeviktor was correct to merge. Opened new PR #169

Please sign in to comment.