fix(cascader): The Cascader component enforces isSelectIconRight to be false to prevent potential style conflicts that may arise when isSelectIconRight is set to true #3852 #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Enter, the value should not change,closed alibaba-fusion#4896
sqq1992
force-pushed
the
fix-issue-3852
branch
3 times, most recently
from
38201f1 to
ebc296a
Compare
zyliang96
reviewed
Dec 5, 2024
components/cascader-select/types.ts
Outdated
| @@ -244,7 +244,7 @@ export interface CascaderSelectProps | |||
| */ | |||
| treeCheckable?: boolean; | |||
| /** | |||
| * 透传到 Cascader 的属性对象 | |||
| * 透传到 Cascader 的属性对象；isSelectIconRight,onItemFocus,onBlur传入无效 | |||
| * @en props object passed to Cascader | |||
components/cascader/cascader.tsx
Outdated
| @@ -109,6 +109,13 @@ const normalizeValue = <T,>(value: T): NormalizeValueReturns<T> => { | |||
| return [] as NormalizeValueReturns<T>; | |||
| }; | |||
|
|
|||
| const getFormatMenuProps = (others: Record<string, unknown>) => { | |||
| return { | |||
| ...pickProps(['onItemFocus', 'onItemClick', 'onItemKeyDown', 'embeddable'], others), | |||
There was a problem hiding this comment.
pickProps 是从里面获取属性，你这里要过滤掉对应数据还是获取数据对应的数据？这里的筛选的参数需要再确定一下
components/cascader/cascader.tsx
Outdated
| @@ -3,7 +3,7 @@ import PropTypes from 'prop-types'; | |||
| import { polyfill } from 'react-lifecycles-compat'; | |||
| import cloneDeep from 'lodash.clonedeep'; | |||
| import cx from 'classnames'; | |||
| import Menu, { type ItemProps, type CheckboxItemProps } from '../menu'; | |||
| import Menu, { type ItemProps, type CheckboxItemProps, type MenuProps } from '../menu'; | |||
| <CascaderSelect dataSource={ChinaArea} menuProps={{ listStyle: { width: '200px' } }} /> | ||
| ); | ||
| cy.get('.next-select').click(); | ||
| cy.get('.next-cascader-menu-wrapper').should('have.css', 'width', '200px'); |
There was a problem hiding this comment.
这个单测不对，即使没有本次的改动，这个单测也是通过的，需要调整成新逻辑下可以透传到Menu的属性进行检测
sqq1992
force-pushed
the
fix-issue-3852
branch
from
ebc296a to
c1325b4
Compare
eternalsky
requested changes
Dec 5, 2024
| @@ -3,6 +3,7 @@ import PropTypes from 'prop-types'; | |||
| import { polyfill } from 'react-lifecycles-compat'; | |||
| import cloneDeep from 'lodash.clonedeep'; | |||
| import cx from 'classnames'; | |||
| import { omit as lodashOmit } from 'lodash'; | |||
| @@ -102,7 +102,20 @@ export interface CascaderMenuProps extends CommonProps, MenuProps { | |||
| */ | |||
| export interface CascaderProps | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3852