Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sticky toc #2445

Closed
wants to merge 1 commit into from
Closed

Conversation

eolesinski
Copy link
Contributor

This PR adds a sticky toc to the Distill template as mentioned in #1961

Changes:

  • adds sticky toc
  • reduces separator line width (for better fit)

@alshedivat
Copy link
Owner

thanks for adding this feature. the only issue I noticed is that transparent background of the sticky toc doesn't look good when the toc bloc starts overlapping with other objects on the page. also, this won't work on mobile well. could you think of a way to fix these issues?

Screenshot 2024-05-27 at 1 01 07 PM Screenshot 2024-05-27 at 1 00 27 PM

@alshedivat alshedivat self-requested a review May 27, 2024 17:03
Copy link
Owner

@alshedivat alshedivat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment about the stylistic issues. these need to be fixed before we can merge this PR. thank you.

@eolesinski
Copy link
Contributor Author

@alshedivat great point - thanks for the feedback. I'll take a look.

@george-gca
Copy link
Collaborator

How did you envision this collapsible toc in this case? Where and how it would appear on mobile? I tend to think that just hiding the toc would be a good use, since the mobile screen is too small to fit both the toc and the contents.

Copy link

stale bot commented Aug 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 3, 2024
@stale stale bot closed this Aug 11, 2024
@hrhoo
Copy link

hrhoo commented Aug 24, 2024

I had a look at the changes.

How about adding this line.
image

When the window is small, it makes the toc fixed

@saguileran
Copy link

Is there any possible and easy solution?

@george-gca
Copy link
Collaborator

@hrhoo can you test if your solution works, and if so, send a PR with this?

jmaycas pushed a commit to jmaycas/jmaycas.github.io that referenced this pull request Dec 21, 2024
Fix custom comments appearing at bottom of page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants