-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sticky toc #2445
add sticky toc #2445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above comment about the stylistic issues. these need to be fixed before we can merge this PR. thank you.
@alshedivat great point - thanks for the feedback. I'll take a look. |
How did you envision this collapsible toc in this case? Where and how it would appear on mobile? I tend to think that just hiding the toc would be a good use, since the mobile screen is too small to fit both the toc and the contents. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Is there any possible and easy solution? |
@hrhoo can you test if your solution works, and if so, send a PR with this? |
Fix custom comments appearing at bottom of page
This PR adds a sticky toc to the Distill template as mentioned in #1961
Changes: