Skip to content

Commit

Permalink
fix: fix the toolset versions for vs2017 and vs2019
Browse files Browse the repository at this point in the history
  • Loading branch information
aminya committed Sep 17, 2021
1 parent e9a591d commit 24f8038
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/msvc/msvc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,19 @@ export async function setupMSVC(
exportVariable("VCTargetsPath", VCTargetsPath)
}
} else if (version === "2017") {
toolset = "15.9.38.0"
await setupChocoPack("visualstudio2017buildtools", toolset, [
toolset = "14.16"
await setupChocoPack("visualstudio2017buildtools", "15.9.38.0", [
"--package-parameters",
"add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive",
])
VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/MSBuild/Microsoft/VC/v150"
VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.16" // TODO verify path
} else if (version === "2019") {
toolset = "16.11.2.0"
await setupChocoPack("visualstudio2019buildtools", toolset, [
toolset = "14.29.30133"
await setupChocoPack("visualstudio2019buildtools", "16.11.2.0", [
"--package-parameters",
"add Microsoft.VisualStudio.Workload.NativeDesktop --includeRecommended --passive",
])
VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/MSBuild/Microsoft/VC/v160"
VCTargetsPath = "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133"
}
if (VCTargetsPath !== undefined && existsSync(VCTargetsPath)) {
exportVariable("VCTargetsPath", VCTargetsPath)
Expand Down

0 comments on commit 24f8038

Please sign in to comment.