[anchore-admission-controller] annotations for the validating webhook configuration #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Degory <[email protected]>
|
@ndegory I'm not sure how this slipped through the cracks, so apologies for the huge delay in review. If you update your base branch I think we can review and get it merged fairly quickly as it seems pretty straightforward. |
zhill
reviewed
Nov 1, 2024
| @@ -4,6 +4,9 @@ kind: ValidatingWebhookConfiguration | |||
| metadata: | |||
| name: {{ template "anchore-admission-controller.name" . }}-admission.anchore.io | |||
| labels: {{- include "anchore-admission-controller.labels" . | nindent 4 }} | |||
| {{- with .Values.apiService.webhook.annotations }} | |||
There was a problem hiding this comment.
It looks like this needs to be '.Values.apiService.annotations' based on the annotation location in the values.yaml and that the 'webhook' level is for the webhook config rather than the api service. Can you verify if that is what's expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configurable annotations for the validating webhook configuration.
This can be used for instance to tell cert-manager to inject a CA cert instead of passing it in the values file.