Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listen_ports_facts: pid is 0 by default #9094

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jean-SebastienG
Copy link

SUMMARY

listen_ports_facts: pid is 0 by default

fix #7620

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

listen_ports_facts

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added docs module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Nov 1, 2024
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 2, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you explain how this is related to #7620?

Also you are modifying the description of a return value, not a module option. There is no way the user can actually set pid.

@@ -113,7 +113,7 @@
type: str
sample: "mysqld"
pid:
description: The pid of the listening process.
description: The pid of the listening process. If user permissions not allowed, set to C(0).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this in a second paragraph. Also use V() for values.

Suggested change
description: The pid of the listening process. If user permissions not allowed, set to C(0).
description:
- The pid of the listening process.
- If user permissions not allowed, set to V(0).

@felixfontein felixfontein added the backport-10 Automatically create a backport for the stable-10 branch label Nov 4, 2024
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. docs module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listen_ports_facts only returns the pid if it is executed as root
3 participants