feat(cli): add removed "core.task_runner" and "core.enable_xcom_pickling" check to command "airflow config lint" #45214
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing" check to command "airflow config lint"
potiuk
approved these changes
Dec 27, 2024
potiuk
reviewed
Dec 27, 2024
| @@ -188,6 +190,9 @@ def message(self) -> str: | |||
| config=ConfigParameter("core", "max_db_retries"), | |||
| renamed_to=ConfigParameter("database", "max_db_retries"), | |||
| ), | |||
| ConfigChange(config=ConfigParameter("core", "task_runner")), | |||
| ConfigChange(config=ConfigParameter("core", "enable_xcom_pickling")), | |||
There was a problem hiding this comment.
Should we keep that one? I think we were going to move away from pickling Xcom?
There was a problem hiding this comment.
Yeah, i think we did it here: #43905.
amoghrajesh
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Config
core.task_runnerandcore.enable_xcom_picklingare removed and will no longer exist in airflow 3.0What
Add lint rules to check these 2 configs
Closes: #45213
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.