-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Beam Go to use the new Opaque Protocol Buffers #33434
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33434 +/- ##
============================================
- Coverage 57.38% 57.31% -0.08%
Complexity 1475 1475
============================================
Files 973 973
Lines 154978 157414 +2436
Branches 1076 1076
============================================
+ Hits 88939 90225 +1286
- Misses 63829 64948 +1119
- Partials 2210 2241 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The failures are code coverage (Protos everywhere!), and unrelated typescript code. |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
The typescript tests have been failing for 9 months https://github.com/apache/beam/actions/workflows/typescript_tests.yml?query=is%3Asuccess and can be ignored as unrelated. |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
See https://go.dev/blog/protobuf-opaque for details on Opaque Protocol Buffers for Go.
This PR has no functional changes, and is almost entirely generated.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.