Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE - testing candidate fixes to Python SDK #33452

Conversation

damondouglas
Copy link
Contributor

DO NOT MERGE - testing candidate fixes to Python SDK


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 60.48387% with 49 lines in your changes missing coverage. Please review.

Project coverage is 57.44%. Comparing base (7c86bf3) to head (129dd8e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../go/pkg/beam/runners/prism/internal/worker/pool.go 63.73% 29 Missing and 4 partials ⚠️
sdks/go/pkg/beam/runners/prism/internal/execute.go 47.36% 7 Missing and 3 partials ⚠️
sdks/go/pkg/beam/runners/prism/prism.go 50.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33452      +/-   ##
============================================
- Coverage     57.46%   57.44%   -0.02%     
  Complexity     1475     1475              
============================================
  Files           979      980       +1     
  Lines        155332   155405      +73     
  Branches       1076     1076              
============================================
+ Hits          89255    89276      +21     
- Misses        63864    63909      +45     
- Partials       2213     2220       +7     
Flag Coverage Δ
go 34.72% <60.48%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant