-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitignore to ignore Visual Studio Code files #90
base: master
Are you sure you want to change the base?
Conversation
Something to consider, it could be worth removing CODE_OF_CONDUCT.md from the root of the repository. Also means when/if the file ever changes, it'll be done for you. No need to copy/paste it over everywhere. This applies to apache/commons-csv as well. |
Hi,
Does the file get included when you build our src zip for a release or
download a repo zip from GitHub?
Our md file just points to the Apache COC page, so there is no effective
duplication.
Gary
…On Sun, Jul 18, 2021, 20:32 Seth Falco ***@***.***> wrote:
Something to consider, it could be worth removing CODE_OF_CONDUCT.md
<https://github.com/apache/commons-beanutils/blob/master/CODE_OF_CONDUCT.md>
from the root of the repository.
Two months ago, it was added to apache/.github
<https://github.com/apache/.github>, so GitHub can infer it from there. (More
Info
<https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file>
)
Also means when/if the file ever changes, it'll be done for you. No need
to copy/paste it over everywhere.
This applies to apache/commons-csv <https://github.com/apache/commons-csv>
as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJB6N7Q632U26ROXVNYUI3TYNXBPANCNFSM5AB4AQDQ>
.
|
No, it just gets displayed in the GitHub UI as if it was in this repository as well. Fair enough! Thanks for the response. |
3a80bac
to
21ea5b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
============================================
+ Coverage 65.06% 65.11% +0.05%
- Complexity 1484 1515 +31
============================================
Files 105 111 +6
Lines 5504 5645 +141
Branches 1068 1086 +18
============================================
+ Hits 3581 3676 +95
- Misses 1464 1490 +26
- Partials 459 479 +20 ☔ View full report in Codecov by Sentry. |
Similar to apache/commons-csv#160