Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to ignore Visual Studio Code files #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Jul 9, 2021

@SethFalco
Copy link
Contributor Author

Something to consider, it could be worth removing CODE_OF_CONDUCT.md from the root of the repository.
Two months ago, it was added to apache/.github, so GitHub can infer it from there. (More Info)

Also means when/if the file ever changes, it'll be done for you. No need to copy/paste it over everywhere.

This applies to apache/commons-csv as well.

@garydgregory
Copy link
Member

garydgregory commented Jul 19, 2021 via email

@SethFalco
Copy link
Contributor Author

Does the file get included when you build our src zip for a release or
download a repo zip from GitHub?

No, it just gets displayed in the GitHub UI as if it was in this repository as well.
(ie when a user tries to make a pull request)

Fair enough! Thanks for the response.

@SethFalco SethFalco changed the title chore: update gitignore to ignore vsc Update .gitignore to ignore Visual Studio Code files Jul 25, 2021
@SethFalco SethFalco force-pushed the chores branch 2 times, most recently from 3a80bac to 21ea5b7 Compare February 4, 2024 15:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.11%. Comparing base (99578cc) to head (25cb092).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #90      +/-   ##
============================================
+ Coverage     65.06%   65.11%   +0.05%     
- Complexity     1484     1515      +31     
============================================
  Files           105      111       +6     
  Lines          5504     5645     +141     
  Branches       1068     1086      +18     
============================================
+ Hits           3581     3676      +95     
- Misses         1464     1490      +26     
- Partials        459      479      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants