Migrate skin to Doxia 2.x

[slawekjaranowski]

No description provided.

[slawekjaranowski]

@garydgregory @michael-o
I have tested with commons parent - one issue what I see is:

<title>About ? Apache Commons</title>

it is generated question mark

[michael-o]

@garydgregory @michael-o I have tested with commons parent - one issue what I see is:

<title>About ? Apache Commons</title>

it is generated question mark

There is an encoding issue some where. ISO-8859-1 somewhere?

[slawekjaranowski]

@garydgregory @michael-o I have tested with commons parent - one issue what I see is:

<title>About ? Apache Commons</title>

it is generated question mark

There is an encoding issue some where. ISO-8859-1 somewhere?

There is: https://github.com/apache/commons-parent/blob/master/pom.xml#L278-L284

after change to utf-8 it is ok 😄

[michael-o]

@garydgregory @michael-o I have tested with commons parent - one issue what I see is:

<title>About ? Apache Commons</title>

it is generated question mark

There is an encoding issue some where. ISO-8859-1 somewhere?

There is: https://github.com/apache/commons-parent/blob/master/pom.xml#L278-L284

after change to utf-8 it is ok 😄

For me, there is ZERO reason to stick to ISO-8859-X these days.

[garydgregory]

@garydgregory @michael-o I have tested with commons parent - one issue what I see is:

<title>About ? Apache Commons</title>

it is generated question mark

There is an encoding issue some where. ISO-8859-1 somewhere?

There is: https://github.com/apache/commons-parent/blob/master/pom.xml#L278-L284

after change to utf-8 it is ok 😄

I will make the change in commons parent and create a release candidate.

[garydgregory]

@slawekjaranowski

Thank you so much for the PR!

I just pushed commit apache/commons-parent@1d943fa to commons-parent.

Would the simplest steps be:

• Set commons.encoding here (commons-skin) to UTF-8
• Release commons-skin 4.3
• In commons-parent, update from commons-skin 4.2 to 4.3
• Release commons-parent 79
• Update other commons component, including commons-skin to commons-parent 79

?

[slawekjaranowski]

@garydgregory

• commons-skin 4.3 - will require m-site-p 3.20.0+
• with m-site-p 3.20.0+ you will need a new version of m-changes-p

so first I would like to finish m-changes-p

[garydgregory]

@slawekjaranowski

OK, TY, I might release a new commons-parent in the meantime, but we'll loop again when m-changes-p is released.

TY again 😄

[slawekjaranowski]

@garydgregory m-changes-p was released we can process forward
I will check again parent if site is ok with this and new m-site-p

[garydgregory]

@slawekjaranowski

Is this OK to merge and release now that maven-changes-plugin 3.0.0-M1 is available?

[slawekjaranowski]

there are tests:

• m-site-p 3.21+ commons-parent#561
• Test parent 79 commons-validator#298

@garydgregory site generation looks ok - please verify and we can go forward

[slawekjaranowski]

@slawekjaranowski

Is this OK to merge and release now that maven-changes-plugin 3.0.0-M1 is available?

yes skin look ok

[garydgregory]

TY @slawekjaranowski
I verified by building local changes to this, commons-parent, and validator.