Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-gen: migrate scalar functions (crypto) documentation #13918

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

Chen-Yuan-Lai
Copy link
Contributor

@Chen-Yuan-Lai Chen-Yuan-Lai commented Dec 27, 2024

Which issue does this PR close?

part of #13671.

Rationale for this change

What changes are included in this PR?

As discussed in #13671, this PR will migrate the builtin hashing functions documentation that currently support migration.

Are these changes tested?

Are there any user-facing changes?

@goldmedal
Copy link
Contributor

Thanks @Chen-Yuan-Lai for working on this
It seems the CI failure can fixed through the following command

- Run # If you encounter an error, run './dev/update_function_docs.sh' and commit
  # If you encounter an error, run './dev/update_function_docs.sh' and commit
  ./dev/update_function_docs.sh

Same as other related PRs.

Comment on lines 44 to 51
- md5
- sha224
- sha256
- sha384
- sha512
- blake2s
- blake2b
- blake3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- md5
- sha224
- sha256
- sha384
- sha512
- blake2s
- blake2b
- blake3"
- md5
- sha224
- sha256
- sha384
- sha512
- blake2s
- blake2b
- blake3"

Maybe we can add some indents for them to format them like
Screenshot 2024-12-28 at 11 38 10 AM

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 28, 2024
@Chen-Yuan-Lai Chen-Yuan-Lai force-pushed the migrate_scalar_functions_crypto branch from 9e58e5f to 6d84829 Compare December 28, 2024 15:09
Copy link
Contributor

@Omega359 Omega359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goldmedal goldmedal merged commit fb5378d into apache:main Dec 29, 2024
28 checks passed
@goldmedal
Copy link
Contributor

Thanks @Chen-Yuan-Lai and @Omega359 for the reviews.

By the way, I modified the description close #13671 to part of #13671 because I think there are other remaining PR waiting for reviewing. We shouldn't close #13671 by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants